Tool calls are failing due to 20s timeout #866
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NAYANAR <[email protected]>
Signed-off-by: NAYANAR <[email protected]>
Nayana-R-Gowda
requested review from
madhav165
and removed request for
crivetimihai
Signed-off-by: NAYANAR <[email protected]>
Signed-off-by: NAYANAR <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: NAYANAR [email protected]
📌 Summary
What problem does this PR fix and why?
This PR fixes the issue of tool calls failing due to a hardcoded 20s timeout by making the timeout configurable.
It ensures longer-running tool executions complete successfully without being forcefully terminated.
💡 Fix Description
How did you solve it? Key design points.
configurable timeout parameter (mcpgateway_ui_tool_test_timeout) instead of using hardcoded values.
This value is passed from settings to the UI and applied consistently in fetchWithTimeout, ensuring flexibility and accurate metrics.
🧪 Verification
make lintmake test📐 MCP Compliance (if relevant)
✅ Checklist
make black isort pre-commit)