Skip to content

Conversation

arjavdongaonkar
Copy link

πŸ› Bug-fix PR

Before opening this PR please:

  1. make lint - passes ruff, mypy, pylint
  2. make test - all unit + integration tests green
  3. make coverage - β‰₯ 90 %
  4. make docker docker-run-ssl or make podman podman-run-ssl
  5. Update relevant documentation.
  6. Tested with sqlite and postgres + redis.
  7. Manual regression no longer fails. Ensure the UI and /version work correctly.

πŸ“Œ Summary

Edit Gateway API does not persist the passthrough_headers field from GatewayUpdate.
Although the field exists in the GatewayUpdate model, it is ignored during update and never stored in the DB.

πŸ” Reproduction Steps

Create a Gateway Server.
Reopen the "Edit" modal.
Fill in the Passthrough Headers input and hit save
Observe that Passthrough headers are not saved
issue: #867

🐞 Root Cause

This was confirmed in the update_gateway method: while it updates name, url, tags, auth, etc., it never checks gateway_update.passthrough_headers.

πŸ’‘ Fix Description

Update passthrough headers as well

πŸ§ͺ Verification

Check Command Status
Lint suite make lint
Unit tests make test
Coverage β‰₯ 90 % make coverage
Manual regression no longer fails steps / screenshots

πŸ“ MCP Compliance (if relevant)

  • Matches current MCP spec
  • No breaking change to MCP clients

βœ… Checklist

  • Code formatted (make black isort pre-commit)
  • No secrets/credentials committed

@arjavdongaonkar arjavdongaonkar force-pushed the fix/passthrough-header-save branch from 557cddb to 22fcf81 Compare September 3, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant