Fix/passthrough header save #868
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Bug-fix PR
Before opening this PR please:
make lint
- passesruff
,mypy
,pylint
make test
- all unit + integration tests greenmake coverage
- β₯ 90 %make docker docker-run-ssl
ormake podman podman-run-ssl
π Summary
Edit Gateway API does not persist the passthrough_headers field from GatewayUpdate.
Although the field exists in the GatewayUpdate model, it is ignored during update and never stored in the DB.
π Reproduction Steps
Create a Gateway Server.
Reopen the "Edit" modal.
Fill in the Passthrough Headers input and hit save
Observe that Passthrough headers are not saved
issue: #867
π Root Cause
This was confirmed in the update_gateway method: while it updates name, url, tags, auth, etc., it never checks gateway_update.passthrough_headers.
π‘ Fix Description
Update passthrough headers as well
π§ͺ Verification
make lint
make test
make coverage
π MCP Compliance (if relevant)
β Checklist
make black isort pre-commit
)