Skip to content

feat(directlink): Support Secrets Manager CRNs for authentication_key#288

Open
anaghajoshiibm wants to merge 2 commits intomasterfrom
dl-secrets-manager-enablement
Open

feat(directlink): Support Secrets Manager CRNs for authentication_key#288
anaghajoshiibm wants to merge 2 commits intomasterfrom
dl-secrets-manager-enablement

Conversation

@anaghajoshiibm
Copy link
Collaborator

PR summary

This PR enables Secret Manager support for Direct Link in the Go SDK.

Fixes: Secret Manager Enablement for DL – Issue #202

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@anaghajoshiibm
Copy link
Collaborator Author

Test cases are also passed:

image

@sridhargk sridhargk requested review from sridhargk and removed request for jkalandaibm and kennburger February 27, 2026 16:18
Copy link
Collaborator

@sridhargk sridhargk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sridhargk
Copy link
Collaborator

Merge this PR during GA time only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants