fix: add missing 404 check for floating IP cleanup in step_create_instance #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tance Fixes duplicate floating IP deletion error when using multiple provisioners. Both step_create_instance and step_waitfor_instance attempt to clean up the same floating IP, but only step_waitfor_instance had the 404 status check. Fixes IBM#133 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
thrix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes duplicate floating IP deletion error when using multiple provisioners. Both step_create_instance and step_waitfor_instance attempt to clean up the same floating IP, but only step_waitfor_instance had the 404 status check.
Fixes #133
🤖 Generated with Claude Code