feat: add support for CodeBlocks with argv #756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starpit
force-pushed
the
argv
branch
2 times, most recently
from
33da24d to
d2d4b21
Compare
starpit
force-pushed
the
argv
branch
3 times, most recently
from
1d19c2d to
44ae7c3
Compare
mandel
reviewed
Mar 14, 2025
Collaborator
mandel
left a comment
mandel
left a comment
There was a problem hiding this comment.
Looks good. There is just a small comment in the code and we could maybe represents args as an expression returning a list of strings (ExpressionType[list[str]]).
src/pdl/pdl_interpreter.py
Outdated
| match block: | ||
| case ArgsBlock(): | ||
| lang = "command" | ||
| code_a, _, _, _ = process_block( |
Collaborator
There was a problem hiding this comment.
You are loosing the trace form the execution of block.args.
starpit
force-pushed
the
argv
branch
6 times, most recently
from
96e68f6 to
3550ead
Compare
Signed-off-by: Nick Mitchell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.