Skip to content

fix: update rust interpreter to avoid global emit/scope state #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
starpit merged 1 commit into from
Apr 10, 2025
Merged

fix: update rust interpreter to avoid global emit/scope state #888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pdl-live-react/src-tauri/src/pdl/ast.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ pub trait SequencingBlock {
fn parser(&self) -> &Option<PdlParser>;
fn to_block(&self) -> PdlBlock;
fn result_for(&self, output_results: Vec<PdlResult>) -> PdlResult;
fn messages_for<T: Clone>(&self, output_messages: Vec<T>) -> Vec<T>;
fn messages_for<T: Clone>(&self, output_messages: &Vec<T>) -> Vec<T>;
}

/// Return the value of the last block if the list of blocks
Expand Down Expand Up @@ -149,7 +149,7 @@ impl SequencingBlock for LastOfBlock {
None => "".into(),
}
}
fn messages_for<T: Clone>(&self, output_messages: Vec<T>) -> Vec<T> {
fn messages_for<T: Clone>(&self, output_messages: &Vec<T>) -> Vec<T> {
match output_messages.last() {
Some(m) => vec![m.clone()],
None => vec![],
Expand Down Expand Up @@ -219,8 +219,8 @@ impl SequencingBlock for TextBlock {
.join("\n"),
)
}
fn messages_for<T: Clone>(&self, output_messages: Vec<T>) -> Vec<T> {
output_messages
fn messages_for<T: Clone>(&self, output_messages: &Vec<T>) -> Vec<T> {
output_messages.clone()
}
}

Expand Down
Loading