lssystemstats collector update to support lssystemstats api update #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shalini-IBM
force-pushed
the
publish/lssystemstats-api-update-support
branch
from
96dd026 to
966652a
Compare
…lssystemstats api (#21) Signed-off-by: Mu Chen <[email protected]> Signed-off-by: SHALINI JHA <[email protected]>
Signed-off-by: SHALINI JHA <[email protected]>
Signed-off-by: SHALINI JHA <[email protected]>
Shalini-IBM
force-pushed
the
publish/lssystemstats-api-update-support
branch
from
9a08576 to
b67b435
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
Change Description
spectrum-virtualize-exporter collector updated to support new nvme_rdma and nvme_tcp metrics added for lssystemstats api. Key based metric desc added to handle any order change in lssystemstats api response.
Related Issue
#29
Test Result
changes validated in dev test setup, below metrics are visible in dashboard
spectrum_systemstats_nvme_rdma_io
spectrum_systemstats_nvme_rdma_mb
spectrum_systemstats_nvme_tcp_mb
spectrum_systemstats_nvme_tcp_io
Unit Test
Integration Test