Skip to content

[OAP] [14722] Fix memory leak caused by asynchronous prefetch #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rui-mo wants to merge 1 commit into from
Closed

[OAP] [14722] Fix memory leak caused by asynchronous prefetch #1388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion velox/common/caching/AsyncDataCache.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ class CoalescedLoad {
return state_;
}

void cancel() {
virtual void cancel() {
setEndState(State::kCancelled);
}

Expand Down
11 changes: 11 additions & 0 deletions velox/dwio/common/DirectBufferedInput.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,17 @@ class DirectCoalescedLoad : public cache::CoalescedLoad {
return size;
}

void cancel() override {
folly::SemiFuture<bool> waitFuture(false);
if (state() == State::kLoading && !loadOrFuture(&waitFuture)) {
waitFuture.wait();
}
for (auto& request : requests_) {
pool_->freeNonContiguous(request.data);
}
CoalescedLoad::cancel();
}

private:
const std::shared_ptr<IoStatistics> ioStats_;
const std::shared_ptr<filesystems::File::IoStats> fsStats_;
Expand Down