Ibmnew/test linux build #424
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyuan
force-pushed
the
ibmnew/test_linux_build
branch
from
127e8e9 to
4a7cb3f
Compare
prestodb-ci
force-pushed
the
main
branch
3 times, most recently
from
77718ca to
f45206c
Compare
zhouyuan
force-pushed
the
ibmnew/test_linux_build
branch
2 times, most recently
from
831a93e to
416831f
Compare
zhouyuan
force-pushed
the
ibmnew/test_linux_build
branch
from
a87a0b5 to
355a9de
Compare
prestodb-ci
force-pushed
the
main
branch
22 times, most recently
from
567c3db to
a4bb14c
Compare
fix decimal avg function precision issue Alchemy-item: (ID = 310) [6020 ] Spark sql avg agg function support decimal commit 1/1 - a464bf5
Alchemy-item: (ID = 311) [oap ] Register merge extract companion agg functions without suffix commit 1/1 - 2de4df7
Alchemy-item: (ID = 313) [11067] Support scan filter for decimal in ORC commit 1/1 - ecf478c
The function toValues removes duplicated values from the vector and return them in a std::vector. It was used to build an InPredicate. It will be needed for building NOT IN filters for Iceberg equality delete read as well, therefore moving it from velox/functions/prestosql/InPred icate.cpp to velox/type/Filter.h. This commit also renames it to deDuplicateValues to make it easier to understand. Alchemy-item: (ID = 441) Iceberg staging hub commit 1/3 - e951481
This commit introduces EqualityDeleteFileReader, which is used to read Iceberg splits with equality delete files. The equality delete files are read to construct domain filters or filter functions, which then would be evaluated in the base file readers. When there is only one equality delete field, and when that field is an Iceberg identifier field, i.e. non-floating point primitive types, the values would be converted to a list as a NOT IN domain filter, with the NULL treated separately. This domain filter would then be pushed to the ColumnReaders to filter our unwanted rows before they are read into Velox vectors. When the equality delete column is a nested column, e.g. a sub-column in a struct, or the key in a map, such column may not be in the base file ScanSpec. We need to add/remove these subfields to/from the SchemaWithId and ScanSpec recursively if they were not in the ScanSpec already. A test is also added for such case. If there are more than one equality delete field, or the field is not an Iceberg identifier field, the values would be converted to a typed expression in the conjunct of disconjunts form. This expression would be evaluated as the remaining filter function after the rows are read into the Velox vectors. Note that this only works for Presto now as the "neq" function is not registered by Spark. See https://github.com/ facebookincubator/issues/12667 Note that this commit only supports integral types. VARCHAR and VARBINARY need to be supported in future commits (see facebookincubator#12664). Co-authored-by: Naveen Kumar Mahadevuni <[email protected]> Alchemy-item: (ID = 441) Iceberg staging hub commit 2/3 - 8cb17fb
….com Alchemy-item: (ID = 441) Iceberg staging hub commit 3/3 - c188f87
Alchemy-item: (ID = 372) Support struct schema evolution matching by name commit 1/1 - 31847be
…Type Alchemy-item: (ID = 446) 13620 fix: Add config for requested type check in ReaderBase::convertType commit 1/1 - a75ae37
Signed-off-by: Yuan <[email protected]> Alchemy-item: (ID = 312) [11771] Fix smj result mismatch issue commit 1/1 - 8c77615
Signed-off-by: Yuan <[email protected]> Alchemy-item: (ID = 444) fix: Adding daily tests commit 1/1 - 14d3376
Signed-off-by: Yuan <[email protected]> Alchemy-item: (ID = 447) fix: Remove website folder to bypass the security issues commit 1/1 - 00fb059
zhouyuan
force-pushed
the
ibmnew/test_linux_build
branch
2 times, most recently
from
5bc3aae to
b7fb0d3
Compare
Signed-off-by: Yuan <[email protected]>
zhouyuan
force-pushed
the
ibmnew/test_linux_build
branch
from
2a4851a to
69745ee
Compare
prestodb-ci
force-pushed
the
main
branch
5 times, most recently
from
1cd00f1 to
e3e8568
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.