Project - Gaspar Vigneaux #129
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for mucss-dataviz pending review.Visit the deploys page to approve it
|
Enchufa2
requested changes
Dec 22, 2025
Member
Enchufa2
left a comment
Enchufa2
left a comment
There was a problem hiding this comment.
I left several comments.
Please ensure that you follow the project guidelines: https://csslab.uc3m.es/dataviz/tutorials/project/#project-guidelines. And let me know when you have 100% completion by marking the pull request as "ready for review" again.
| @@ -0,0 +1,775 @@ | |||
| --- | |||
| title: "SHOWING THE RACE OR ORIGIN PERCENTAGES OF EACH STATE" | |||
Member
There was a problem hiding this comment.
Please avoid all caps in titles.
| title: "SHOWING THE RACE OR ORIGIN PERCENTAGES OF EACH STATE" | ||
| description: | | ||
| Replicating spiral charts and exploring alternative designs for clarity. | ||
| author: Gaspar Vigneaux |
| description: | | ||
| Replicating spiral charts and exploring alternative designs for clarity. | ||
| author: Gaspar Vigneaux | ||
| date: 2025-11-24 |
Member
There was a problem hiding this comment.
"`r Sys.Date()`", see the tutorial
Comment on lines
756
to
772
| ggsave( | ||
| "improvement_trial.png", | ||
| final_layout_sidebyside, | ||
| width = 20, | ||
| height = 12, | ||
| dpi = 600, | ||
| bg = "white" | ||
| ) | ||
|
|
||
| ggsave( | ||
| "improvement_trial.pdf", | ||
| final_layout_sidebyside, | ||
| width = 20, | ||
| height = 12, | ||
| device = "pdf", | ||
| bg = "white" | ||
| ) |
Member
There was a problem hiding this comment.
I suppose this was for the presentation? Remove calls to ggsave, please, and let the chunks speak for themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my almost final version, i still have things to improve like the legends key and the formatting.