fix: use unique logger name per job to prevent log handler conflicts#219
Merged
srmnitc merged 1 commit intoICAMS:mainfrom Mar 2, 2026
Merged
fix: use unique logger name per job to prevent log handler conflicts#219srmnitc merged 1 commit intoICAMS:mainfrom
srmnitc merged 1 commit intoICAMS:mainfrom
Conversation
keyurrmaniya
commented
Mar 2, 2026
keyurrmaniya
commented
- logging.getLogger(name) returned same singleton for all jobs; each new job cleared previous job's file handler silently. Fixed by using log file path as unique logger name.
- Propagate MeltingTemp handlers to Solid/Liquid sub-job loggers so all sub-job output also appears in melting_temperature.log.
- Fix np.NaN -> np.nan for NumPy 2.0 compatibility.
- Add tests for no handler accumulation and no cross-contamination.
- logging.getLogger(__name__) returned same singleton for all jobs; each new job cleared previous job's file handler silently. Fixed by using log file path as unique logger name. - Propagate MeltingTemp handlers to Solid/Liquid sub-job loggers so all sub-job output also appears in melting_temperature.log. - Fix np.NaN -> np.nan for NumPy 2.0 compatibility. - Add tests for no handler accumulation and no cross-contamination.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.