Skip to content

Conversation

@stacyrse
Copy link

@github-actions
Copy link

github-actions bot commented Jan 22, 2025

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/ICR-RSE-Group/carpentry-pando-python/compare/md-outputs..md-outputs-PR-1

The following changes were observed in the rendered markdown documents:

 md5sum.txt                                 | 12 +++++------
 optimisation-data-structures-algorithms.md | 14 ++++++-------
 optimisation-introduction.md               | 28 ++++++--------------------
 optimisation-minimise-python.md            | 32 +++++++++++++++---------------
 profiling-functions.md                     | 16 +++++++--------
 profiling-introduction.md                  | 14 ++++++-------
 profiling-lines.md                         | 10 +++++-----
 7 files changed, 54 insertions(+), 72 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-01-22 16:49:56 +0000

@stacyrse stacyrse requested a review from msarkis-icr January 22, 2025 16:49
github-actions bot pushed a commit that referenced this pull request Jan 22, 2025
@stacyrse stacyrse marked this pull request as ready for review January 23, 2025 10:36
@stacyrse
Copy link
Author

Draft pull request has been approved by the reviewer (MIra) -> merging the pull request without another review

@stacyrse stacyrse merged commit e00e48e into main Jan 23, 2025
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 23, 2025
Auto-generated via `{sandpaper}`
Source  : e00e48e
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-23 13:08:52 +0000
Message : Merge pull request #1 from ICR-RSE-Group/fix-issue-21

Fix issue 21 - reviewing the optimisation course
github-actions bot pushed a commit that referenced this pull request Jan 23, 2025
Auto-generated via `{sandpaper}`
Source  : d0be0bd
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-23 13:10:06 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : e00e48e
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-23 13:08:52 +0000
Message : Merge pull request #1 from ICR-RSE-Group/fix-issue-21

Fix issue 21 - reviewing the optimisation course
github-actions bot pushed a commit that referenced this pull request Jan 28, 2025
Auto-generated via `{sandpaper}`
Source  : d0be0bd
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-23 13:10:06 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : e00e48e
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-23 13:08:52 +0000
Message : Merge pull request #1 from ICR-RSE-Group/fix-issue-21

Fix issue 21 - reviewing the optimisation course
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants