Skip to content

Conversation

@msarkis-icr
Copy link

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 29, 2025

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/ICR-RSE-Group/carpentry-pando-python/compare/md-outputs..md-outputs-PR-2

The following changes were observed in the rendered markdown documents:

 config.yaml                                |  1 -
 md5sum.txt                                 | 11 ++++-----
 optimisation-data-structures-algorithms.md | 20 +++++++++-------
 optimisation-introduction.md               |  8 +++----
 optimisation-memory.md                     | 38 +++++++++++++-----------------
 optimisation-minimise-python.md            | 15 ++++++------
 registration.md (gone)                     | 18 --------------
 7 files changed, 45 insertions(+), 66 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-01-29 16:43:21 +0000

@msarkis-icr msarkis-icr requested a review from stacyrse January 29, 2025 15:49
github-actions bot pushed a commit that referenced this pull request Jan 29, 2025
Copy link

@stacyrse stacyrse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest is much better than the original!

To retrieve or check for the existence of a key within a hashing data structure, the key is hashed again and a process equivalent to insertion is repeated. However, now the key at each index is checked for equality with the one provided. If any empty index is found before an equivalent key, then the key must not be present in the ata structure.

When a dictionary or hash table in Python grows, the underlying storage is resized, which necessitates re-inserting every existing item into the new structure. This process can be computationally expensive but is essential for maintaining efficient average probe times when searching for keys.
![An visual explanation of linear probing, CPython uses an advanced form of this.](episodes/fig/hash_linear_probing.png){alt="A iagram showing how keys (hashes) 37, 64, 14, 94, 67 are inserted into a hash table with 11 indices. The insertion of 59, 80, and 39 demonstrates linear probing to resolve collisions."}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'a diagram' not iagram!

To retrieve or check for the existence of a key within a hashing data structure, the key is hashed again and a process equivalent to insertion is repeated. However, now the key at each index is checked for equality with the one provided. If any empty index is found before an equivalent key, then the key must not be present in the ata structure.

When a dictionary or hash table in Python grows, the underlying storage is resized, which necessitates re-inserting every existing item into the new structure. This process can be computationally expensive but is essential for maintaining efficient average probe times when searching for keys.
![An visual explanation of linear probing, CPython uses an advanced form of this.](episodes/fig/hash_linear_probing.png){alt="A iagram showing how keys (hashes) 37, 64, 14, 94, 67 are inserted into a hash table with 11 indices. The insertion of 59, 80, and 39 demonstrates linear probing to resolve collisions."}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'a visual' not 'an visual'!

github-actions bot pushed a commit that referenced this pull request Jan 29, 2025
@msarkis-icr msarkis-icr merged commit bbfb7be into main Jan 29, 2025
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 29, 2025
Auto-generated via `{sandpaper}`
Source  : bbfb7be
Branch  : main
Author  : msarkis-icr <[email protected]>
Time    : 2025-01-29 16:46:35 +0000
Message : Merge pull request #2 from ICR-RSE-Group/fix_issue_21_bis

Simplifying text in different sections
github-actions bot pushed a commit that referenced this pull request Jan 29, 2025
Auto-generated via `{sandpaper}`
Source  : 3fbb41c
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-29 16:47:28 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : bbfb7be
Branch  : main
Author  : msarkis-icr <[email protected]>
Time    : 2025-01-29 16:46:35 +0000
Message : Merge pull request #2 from ICR-RSE-Group/fix_issue_21_bis

Simplifying text in different sections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants