Skip to content

Conversation

@stacyrse
Copy link

My changes were minimal because you actually did all the work for me @msarkis-icr ... I added the image and have no idea how its going to look in the final version - VSCode previewer doesn't let you see it...

@github-actions
Copy link

github-actions bot commented Jan 29, 2025

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/ICR-RSE-Group/carpentry-pando-python/compare/md-outputs..md-outputs-PR-3

The following changes were observed in the rendered markdown documents:

 fig/python_lists.png (new)                 | Bin 0 -> 458269 bytes
 md5sum.txt                                 |   4 ++--
 optimisation-data-structures-algorithms.md |  21 ++++++++++++++++++---
 optimisation-memory.md                     |   2 --
 4 files changed, 20 insertions(+), 7 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-01-30 12:59:53 +0000

github-actions bot pushed a commit that referenced this pull request Jan 29, 2025
@stacyrse
Copy link
Author

Update Mira's comment:
i think it s only missing one point:
We don't want people to get afraid of using dict(). We can say something like : "Dictionaries are designed to handle insertions efficiently, with average-case O(1) time complexity per insertion for a small size dict. But it is problematic for large size dict. In this case, we 'd better find an alternative (list, numpy and panda lists)"
and the recap. table for using what in which cases

github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
@stacyrse stacyrse marked this pull request as ready for review January 30, 2025 11:56
@stacyrse stacyrse requested a review from msarkis-icr January 30, 2025 11:57
Copy link

@msarkis-icr msarkis-icr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the table and added some specifications

github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
@stacyrse stacyrse merged commit 3320f94 into main Jan 30, 2025
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Feb 4, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Feb 18, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Mar 4, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Mar 11, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Mar 18, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Mar 25, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Apr 1, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Apr 8, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Apr 15, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Apr 22, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Apr 29, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request May 6, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request May 13, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request May 20, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request May 27, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Jun 3, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Jun 10, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Jun 17, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Jun 24, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Jul 1, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Jul 8, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Jul 15, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Jul 22, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Jul 29, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Aug 5, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Aug 12, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Aug 19, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Aug 26, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
github-actions bot pushed a commit that referenced this pull request Sep 2, 2025
Auto-generated via `{sandpaper}`
Source  : 1c0b449
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-30 17:55:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 3320f94
Branch  : main
Author  : Stacy Shcherbakova <[email protected]>
Time    : 2025-01-30 17:54:21 +0000
Message : Merge pull request #3 from ICR-RSE-Group/fix-issue-21-ss

Fix issue 21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants