Fix issue 28 #29
Draft
Fix issue 28 #29
+40
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I would prefer we discuss the spec for this before coding! I added some thoughts in the issue. |
Contributor
|
Plus also this is an example of a test case that should be added as part of a change. The test case shows the functionality. |
rachelicr
approved these changes
Apr 16, 2025
Contributor
rachelicr
left a comment
rachelicr
left a comment
There was a problem hiding this comment.
Looks good, I haven't tested it but will do tomorrow if it is updated to main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add group info to the ssh class, filled upon construction and accessed using a getter
get_user_groupsNew functions to retrieve default user paths:
get_user_paths. The constructor requires now a new argument which is yaml file path:custom_yaml