[GCDEV-125 Added title attribute and aria-label for accessibility]#9
Open
wiebe0601 wants to merge 3 commits intodevelopmentfrom
Open
[GCDEV-125 Added title attribute and aria-label for accessibility]#9wiebe0601 wants to merge 3 commits intodevelopmentfrom
wiebe0601 wants to merge 3 commits intodevelopmentfrom
Conversation
paulvanbuuren
requested changes
Jul 8, 2025
Collaborator
paulvanbuuren
left a comment
paulvanbuuren
left a comment
There was a problem hiding this comment.
Teksten moeten nog vertaald worden.
ictuwp-plugin-rijksvideo.php
Outdated
|
|
||
| $video_attributes = [ | ||
| 'id' => $video_id, | ||
| 'title' => $video_title, |
Collaborator
There was a problem hiding this comment.
Waarom een title-attribuut en waarom is de tekst hiervan anders dan het arialabel?
Author
There was a problem hiding this comment.
Goeie vragen waarom de tekst verschillend is in theorie zou alleen de titel en het titel element voldoende moeten zijn, maar ik dacht ik doe er ook een aria-label bij.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.