Update Help.ShowHelp topic IDs in metadata user controls#10191
Update Help.ShowHelp topic IDs in metadata user controls#10191ARMSTRONGOPONDO wants to merge 2 commits intoIDEMSInternational:masterfrom
Conversation
Updated the help topic IDs in Help.ShowHelp calls for both ucrColumnMetadata and ucrDataFrameMetadata. Changed IDs to "697" for most help menu items and to "134" for HelpToolStripMenuItem_Click in ucrDataFrameMetadata.
Summary of ChangesHello @ARMSTRONGOPONDO, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the accuracy of the application's help system by correcting outdated topic ID mappings. By updating the identifiers used in Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request successfully updates the help topic IDs in ucrColumnMetadata and ucrDataFrameMetadata as specified in the description. The changes are straightforward and directly address the help ID mapping issue. No further issues were identified within the scope of the provided changes and review criteria.
|
@ARMSTRONGOPONDO thanks. Is this ready to review? |
|
@lilyclements from your earlier comment on the issue with regards to how we know these are the correct help ids, we mostly get the help ids from @rdstern and @rachelkg so they would be the best to confirm and approve this PR |
|
@berylwaswa I still can't seem to check pull requests. I am talking to Danny to try to figure it out, but for now, please could you check in my place. All you need to do is click on the help buttons and check that they go to the right help pages. If you have questions feel free to share pictures and I can take a look. Thanks, |
berylwaswa
left a comment
There was a problem hiding this comment.
@ARMSTRONGOPONDO, this is working fine and taking me to the help for the right-click menus.
|
@berylwaswa could you review this again I just did a minor change after reviewing @rachelkg input on issue #9831 |
@lilyclements @derekagorhom Updated the help topic IDs in Help.ShowHelp calls for both ucrColumnMetadata and ucrDataFrameMetadata. Changed IDs to "697" for most help menu items and to "134" for HelpToolStripMenuItem_Click in ucrDataFrameMetadata. This pull request is addressing the help id mapping on #9831
Before asking for review
Please confirm that you have:
Developer Testing Checklist