Closed
Conversation
Collaborator
Author
|
Tested in-game with extensions\src\ACRE2Arma\signal\models\longleyRice.cpp:75 to manually get a 3 capacity array |
jonpas
approved these changes
Jul 8, 2025
Member
|
Hmm. While this would indeed fix the crash, this is not fixing the root problem. Why does it happen in the first place? LR is one of the must fucked up codes i have ever seen, partly due to being a port of FORTRAN. So any code modification must be tested with different combination of paths and compare it with the original implementation. |
Member
|
Replaced by #1407. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3 Crashdumps from dedman
Different maps, but all using long rice, crashing in same spot
in all 3 cases elev is only size 3 and
iis going off the endThis PR should fix the overrun (and keep the average correct)
But I couldn't replicate issue locally, so I can't be positive it will fully solve root issue