Addresses issue #1412 and fixes SEM52SL RX#1416
Closed
elitewill1200 wants to merge 3 commits intoIDI-Systems:masterfrom
Closed
Addresses issue #1412 and fixes SEM52SL RX#1416elitewill1200 wants to merge 3 commits intoIDI-Systems:masterfrom
elitewill1200 wants to merge 3 commits intoIDI-Systems:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The channel spacing is hard-coded to 25 Khz, meaning the 5th digit can only ever be a 0 or 5 or 8 (radio set to show 88888 on startup). 2 and 6 are unused and not included in backlit versions so a simple comment fixes this.
To address SM52 SL not receiving, the issue was caused by a NaN comparison. For whatever reason the same channel selection that is used on other radios in the fnc_handleMultipleTransmissions fails, simply replaced it with a known working method in the same function.