Bugfix/confusing solver warning#1521 open #1537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could you please a run a |
kbirken
requested changes
Dec 3, 2025
Member
kbirken
left a comment
kbirken
left a comment
There was a problem hiding this comment.
Here are some findings from my review:
- The method
ICanRunCheckManually.highlightWarning()should be overridden (with bodytrue) forICheckableTabularVarPointinstead ofFeatureDecTab(this is more general). - The method
ICanRunCheckManually.highlightWarning()should also be overridden (with bodytrue) forIVariabilityAwareArtifact. - Findings in
Check_ICanRunCheckManuallyUtil- The debug outputs in
run()should be removed. - After moving
run()into the class the other two static methods can be private. For the calls to these methods I would prefer using intentionConvertLocalStaticMethodCall, this is more readable. - The class is used only from the typesystem aspect. You could move it there.
- Optional: After it is moved to the typesystem aspect, you could add a "CheckingMethod" annotation (see below, use the annotation from
jetbrains.mps.lang.typesystem.dependencies). Then you can call error, warning, info directly without passing the lambdas. (But then the test won't work without changes). Remark: I am not sure if CheckingMethods work for static methods.
- The debug outputs in
…solver-warning#1521-Open- # Conflicts: # code/languages/org.iets3.opensource/languages/org.iets3.variability.configuration.base/models/org.iets3.variability.configuration.base.behavior.mps # code/languages/org.iets3.opensource/solutions/org.iets3.opensource.build/models/org/iets3/opensource/build/build.mps
Member
|
@kbirken could you maybe have a second look? |
Member
Author
|
@kbirken can you continue? |
Member
I tried yesterday, did not build locally. I have to find out what the problem is... |
kbirken
approved these changes
Dec 10, 2025
Member
kbirken
left a comment
kbirken
left a comment
There was a problem hiding this comment.
Looks good now, thank for addressing the findings!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #1521
I added a flag to 'ICanRunCheckManually' to switch of the mentioned warning (as the default value is false).
For FeatureModel, FeatureModelConfig and FeatureDecTab it is true.
But for those concepts the checking_rule (http://127.0.0.1:63320/node?ref=r%3Ae5a2b77c-569f-4c13-8679-6ec5a6000fa9%28org.iets3.core.base.typesystem%29%2F3025732926363202325)
is not used to propagate the warning. FeatureDecTab is solved 'i typesystem' not manually.
The other two trigger an asynchronous task which does not trigger the rule.
Thus. there is only one test ensuring that for an ISolvable an warning is not issued.