#688 Avoid colon casts in type system #1550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 5, 2025 12:04
Member
|
fixes #688 |
Member
|
This looks good to me, but because there are so many affected nodes, I would like to ask some of the others reviewers to also have a look. @arimer @jonaskraemer thanks! |
nkoester
previously approved these changes
Dec 9, 2025
arimer
reviewed
Dec 9, 2025
Member
arimer
left a comment
arimer
left a comment
There was a problem hiding this comment.
Could you please update the changelog as well?
Member
done |
Member
|
@nkoester what was the motivation for not only converting TS rules but also: quickfixes, helper classes, behaviour methods etc.? |
Member
|
All of these were within the typesystem and the context thereof. Or at least called from the typesystem. From my perspective |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the type system expects a certain concept, we should not use the colon cast (:) to cast nodes to a different type but rather use the as cast. This cast returns null if the cast is not successful, for example when a user provides a node of a wrong type or the RuntimeErrorType is returned. I've fixed a few of such issues in the past but there are so many hidden cases, it's probably better to just ban this cast and replace all instances in the type system.