Skip to content

Conversation

gregcorbett
Copy link

Description

APEL received reports of non-ascii characters in usernames causing problems, so this PR filters them out by treating them in the same way as non-ascii characters in VM names.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change is a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

- treat in the same way as non-ascii characters
  in VM names.
@gregcorbett gregcorbett force-pushed the non-ascii-usernames branch from ddf5e2e to a4a76e6 Compare May 14, 2025 08:30
Copy link

@gregcorbett gregcorbett marked this pull request as ready for review May 14, 2025 08:31
@gregcorbett
Copy link
Author

is there any feedback on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant