Skip to content

chore(index_and_notify): use exc_info and logger_context with logger.error #2566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore(index_and_notify): use exc_info and logger_context with logger.error #2566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions api/management/commands/index_and_notify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
)
from deployments.models import ERU, Personnel, PersonnelDeployment
from main.sentry import SentryMonitor
from main.utils import logger_context
from notifications.hello import get_hello
from notifications.models import RecordType, Subscription, SubscriptionType, SurgeAlert
from notifications.notification import send_notification
Expand Down Expand Up @@ -922,12 +923,16 @@ def index_records(self, records, to_create=True):
def bulk(self, actions):
try:
created, errors = bulk(client=ES_CLIENT, actions=actions)
if len(errors):
logger.error("Produced the following errors:")
logger.error("[%s]" % ", ".join(map(str, errors)))
except Exception as e:
logger.error("Could not index records")
logger.error("%s..." % str(e)[:512])
if errors:
logger.error(
"(index_and_notify:bulk): produced errors:",
extra=logger_context(dict(errors=errors)),
)
except Exception:
logger.error(
"(index_and_notify:bulk): could not index records",
exc_info=True,
)

# Remove items in a queryset where updated_at == created_at.
# This leaves us with only ones that have been modified.
Expand Down
Loading