Refactor bulk upload logic for XLSX file processing #2575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudip-khanal
requested review from
Rup-Narayan-Rajbanshi,
sandeshit,
sudan45,
susilnem and
thenav56
susilnem
requested changes
Oct 31, 2025
local_units/bulk_upload.py
Outdated
|
|
||
| self._validate_csv(fieldnames) | ||
| except BulkUploadError as e: | ||
| workbook = openpyxl.load_workbook(file, data_only=True) |
There was a problem hiding this comment.
Suggested change
| workbook = openpyxl.load_workbook(file, data_only=True) | |
| workbook = openpyxl.load_workbook(file, read_only=True) |
| buffer = io.BytesIO() | ||
| self._workbook.save(buffer) | ||
| buffer.seek(0) | ||
| return ContentFile(buffer.getvalue()) |
There was a problem hiding this comment.
Verify if we need the encoding here!
sudip-khanal
force-pushed
the
feat/add-xlsx-import-template
branch
from
77fac75 to
e818755
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
Changes
Checklist
Things that should succeed before merging.
Release
If there is a version update, make sure to tag the repository with the latest version.