eap(eap-registration-form): Add EAP Registration Form #2046

barshathakuri · 2025-10-15T10:00:09Z

Summary

Add EAP Registration Form.

Addresses

No issue

Changes

Add EAP Registration Form

This PR Ensures:

No typos or grammatical errors
No conflict markers left in the code
No unwanted comments, temporary files, or auto-generated files
No inclusion of secret keys or sensitive data
No console.log statements meant for debugging
All CI checks have passed

Additional Notes

Optional: Add any other relevant context, screenshots, or details here.

changeset-bot · 2025-10-15T10:00:14Z

⚠️ No Changeset found

Latest commit: 20d7ef9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

AdityaKhatri · 2025-10-15T10:17:45Z

app/src/views/EapRegistration/index.tsx

+                <InputSection
+                    title="National Society (NS)"
+                    description="Select National Society that is planning to apply for the EAP"
+                    withAsteriskOnTitle
+                >
+                    <NationalSocietySelectInput
+                        error={undefined}
+                        name="national_society"


This is a good go ahead, but @barshathakuri , you need to create a typing, setup form and then create inputs. The form needs to be editable and working, only the send action is stopped. Only after we do this, we can change things easily later on.

shreeyash07 · 2025-10-28T04:16:43Z

app/src/views/EapRegistration/schema.ts

+
+type FormSchema = ObjectSchema<PartialFormFields>;
+export const formSchema: FormSchema = {
+    fields: (value) => ({


Do we need to make every field required?

shreeyash07 · 2025-10-28T04:18:48Z

app/src/views/EapRegistration/index.tsx

+    } = props;
+
    const strings = useTranslation(i18n);
+    const defaultFormValue = useMemo(() => ({


After removing every field required we can have default value empty.

AdityaKhatri

Make sure all input components have error handled. Add nonFieldErrors as well. Also, make sure select componets have their options fetched if they are there.

AdityaKhatri · 2025-10-31T05:42:08Z

app/src/views/EapRegistration/index.tsx

+const eapFormOptions = [
+    { value: 'full', label: 'Full application' },
+    { value: 'simplified', label: 'Simplified application' },
+    { value: 'not_sure', label: 'Not Sure' },
+];


Use translation

This is dummy data. I'll be an Enum.

AdityaKhatri · 2025-10-31T05:42:47Z

app/src/views/EapRegistration/index.tsx

+interface Props {
+    disabled?: boolean;
+}


Always keep props next to the component

AdityaKhatri · 2025-10-31T05:43:11Z

app/src/views/EapRegistration/index.tsx

+                        keySelector={(option) => option.value}
+                        labelSelector={(option) => option.label}


Define these outside plz

AdityaKhatri · 2025-10-31T05:43:21Z

app/src/views/EapRegistration/index.tsx

+                        value={value?.eap_start_date}
+                    />
+                    <DateInput
+                        name="eap_end_date"
+                        onChange={setFieldValue}
+                        value={value?.eap_end_date}


Add errors here

AdityaKhatri · 2025-10-31T05:43:39Z

app/src/views/EapRegistration/index.tsx

+                        onChange={setFieldValue}
+                        keySelector={partnerInvolvedKeySelector}
+                        labelSelector={partnerInvolvedLabelSelector}
+                        options={[]}


Where do we fetch this from? Either implement or add FIXME

AdityaKhatri · 2025-10-31T05:44:12Z

app/src/views/EapRegistration/index.tsx

+                <Button
+                    name={undefined}
+                    onClick={handleFormSubmit}
+                    type="submit"
+                    variant="secondary"
+                    disabled={disabled}
+                >
+                    {strings.eapSubmitButton}
+                </Button>


We'll probably need a cancel button too right?

We have a submit button only in figma. Do we need to add the cancel button as well?
We also have a cancel button on the top of the form.

barshathakuri temporarily deployed to test October 15, 2025 10:00 — with GitHub Actions Inactive

barshathakuri marked this pull request as draft October 15, 2025 10:00

barshathakuri temporarily deployed to test October 15, 2025 10:00 — with GitHub Actions Inactive

barshathakuri temporarily deployed to test October 15, 2025 10:01 — with GitHub Actions Inactive

barshathakuri requested a review from shreeyash07 October 15, 2025 10:07

AdityaKhatri reviewed Oct 15, 2025

View reviewed changes

barshathakuri force-pushed the feature/eap-registration-form branch from d496188 to 4a259ca Compare October 15, 2025 11:07

barshathakuri temporarily deployed to test October 15, 2025 11:08 — with GitHub Actions Inactive

barshathakuri temporarily deployed to test October 15, 2025 11:09 — with GitHub Actions Inactive

barshathakuri force-pushed the feature/eap-registration-form branch from 4a259ca to e91a814 Compare October 27, 2025 05:14

barshathakuri temporarily deployed to test October 27, 2025 05:14 — with GitHub Actions Inactive

barshathakuri temporarily deployed to test October 27, 2025 05:15 — with GitHub Actions Inactive

barshathakuri temporarily deployed to test October 27, 2025 05:16 — with GitHub Actions Inactive

barshathakuri force-pushed the feature/eap-registration-form branch from e91a814 to 6bc8692 Compare October 27, 2025 10:58

barshathakuri temporarily deployed to test October 27, 2025 10:58 — with GitHub Actions Inactive

barshathakuri temporarily deployed to test October 27, 2025 10:59 — with GitHub Actions Inactive

shreeyash07 requested changes Oct 28, 2025

View reviewed changes

barshathakuri force-pushed the feature/eap-registration-form branch from 6bc8692 to 712bf90 Compare October 28, 2025 07:37

barshathakuri temporarily deployed to test October 28, 2025 07:38 — with GitHub Actions Inactive

barshathakuri marked this pull request as ready for review October 28, 2025 07:38

barshathakuri requested review from AdityaKhatri and shreeyash07 October 28, 2025 07:38

barshathakuri assigned AdityaKhatri and shreeyash07 Oct 28, 2025

barshathakuri temporarily deployed to test October 28, 2025 07:38 — with GitHub Actions Inactive

barshathakuri temporarily deployed to test October 28, 2025 07:39 — with GitHub Actions Inactive

AdityaKhatri requested changes Oct 31, 2025

View reviewed changes

eap(eap-registration-form): Add EAP Registration Form

20d7ef9

barshathakuri force-pushed the feature/eap-registration-form branch from 712bf90 to 20d7ef9 Compare November 4, 2025 05:19

barshathakuri temporarily deployed to test November 4, 2025 05:19 — with GitHub Actions Inactive

barshathakuri temporarily deployed to test November 4, 2025 05:20 — with GitHub Actions Inactive

barshathakuri temporarily deployed to test November 4, 2025 05:21 — with GitHub Actions Inactive

barshathakuri requested a review from AdityaKhatri November 5, 2025 06:38

		keySelector={(option) => option.value}
		labelSelector={(option) => option.label}

eap(eap-registration-form): Add EAP Registration Form #2046

Are you sure you want to change the base?

eap(eap-registration-form): Add EAP Registration Form #2046

Uh oh!

Conversation

barshathakuri commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Addresses

Changes

This PR Ensures:

Additional Notes

Uh oh!

changeset-bot bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AdityaKhatri left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

barshathakuri commented Oct 15, 2025 •

edited

Loading

changeset-bot bot commented Oct 15, 2025 •

edited

Loading