Confirmation modal for new both DREF Operational Update and final report #2048
Conversation
shreeyash07
requested review from
AdityaKhatri,
barshathakuri and
frozenhelium
|
shreeyash07
changed the title
| @@ -1,11 +1,11 @@ | |||
| { | |||
| "parent": "000051-1758354992698.json", | |||
There was a problem hiding this comment.
Lets remove translation migration for now. We can do that all together in the future.
There was a problem hiding this comment.
this might be the last PR for the Project branch,
| formData: true, | ||
| url, | ||
| method: 'POST', | ||
| useCurrentLanguageForMutation: true, |
There was a problem hiding this comment.
We should pass this down as prop and use it only where necessary, this might affect the other places where input is currently being used
| // FIXME: fix typing in server (low priority) | ||
| // the server generated type for response and body is the same | ||
| body: (body) => body as never, | ||
| useCurrentLanguageForMutation: true, |
There was a problem hiding this comment.
We should pass this down as prop and use it only where necessary, this might affect the other places where input is currently being used
| .add-ops-update-modal { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: var(--go-ui-spacing-lg); | ||
| } |
There was a problem hiding this comment.
Yes it is needed for now.
| } else if (method === 'POST' || method === 'PUT' || method === 'PATCH') { | ||
| // Mutation | ||
| defaultHeaders['Accept-Language'] = useCurrentLanguageForMutation ? currentLanguage : 'en'; | ||
| if (isDefined(enforceLanguageForMutation)) { | ||
| defaultHeaders['Accept-Language'] = enforceLanguageForMutation; | ||
| } else if (useCurrentLanguageForMutation) { | ||
| defaultHeaders['Accept-Language'] = currentLanguage; | ||
| } else { | ||
| defaultHeaders['Accept-Language'] = 'en'; | ||
| } |
There was a problem hiding this comment.
We might need to add default fallback as well
There was a problem hiding this comment.
Let's remove this file for now, the project branch already has 2 migration file which starts with 52
Addresses
Depends On
Changes
This PR Ensures:
console.logstatements meant for debugging