Skip to content

EAP Full export #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
shreeyash07 wants to merge 10 commits into
base: feature/eap-full-form
Choose a base branch
from
Draft

EAP Full export #2178

shreeyash07 wants to merge 10 commits into from

Conversation

@shreeyash07
Copy link
Collaborator

@shreeyash07 shreeyash07 commented Jan 8, 2026

Summary

Provide a brief description of what this PR addresses and its purpose.

Addresses

  • Issue(s): List related issues or tickets.

Depends On

  • Other PRs or Dependencies: List PRs or dependencies this PR relies on.

Changes

  • Detailed list or prose of changes
  • Breaking changes
  • Changes to configurations

This PR Ensures:

  • No typos or grammatical errors
  • No conflict markers left in the code
  • No unwanted comments, temporary files, or auto-generated files
  • No inclusion of secret keys or sensitive data
  • No console.log statements meant for debugging
  • All CI checks have passed

Additional Notes

Optional: Add any other relevant context, screenshots, or details here.

@changeset-bot
Copy link

changeset-bot bot commented Jan 8, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: a450334

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@shreeyash07 shreeyash07 changed the base branch from project/early-action-protocols to feature/eap-full-form January 8, 2026 09:06
@shreeyash07 shreeyash07 force-pushed the feature/eap-full-export branch from 6b66c26 to e60b44d Compare January 8, 2026 09:50
@shreeyash07 shreeyash07 force-pushed the feature/eap-full-export branch from e60b44d to a450334 Compare January 8, 2026 10:43
frozenhelium
frozenhelium requested changes Jan 9, 2026
View reviewed changes
app/src/views/EapExport/index.tsx
Copy link
Member

@frozenhelium frozenhelium Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be converted to a Layout route

app/src/views/EapFullExport/index.tsx
Copy link
Member

@frozenhelium frozenhelium Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make the component name consistent

app/src/views/SimplifiedEapExport/index.tsx
layout="grid"
spacing="2xs"
>
<ListView layout="grid" spacing="2xs">
Copy link
Member

@frozenhelium frozenhelium Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not needed!

app/src/views/SimplifiedEapExport/index.tsx
<PrintableDescription
value={strings.contactInformationDescription}
/>
<PrintableDescription value={strings.contactInformationDescription} />
Copy link
Member

@frozenhelium frozenhelium Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not needed

app/src/views/SimplifiedEapExport/index.tsx
heading={strings.nationalHeading}
headingLevel={4}
>
<PrintableContainer heading={strings.nationalHeading} headingLevel={4}>
Copy link
Member

@frozenhelium frozenhelium Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the unnecessary changes, this will only cause conflict during the rebase

@shreeyash07 shreeyash07 force-pushed the feature/eap-full-form branch from 5522fad to a92b469 Compare January 9, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frozenhelium frozenhelium frozenhelium requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shreeyash07 @frozenhelium