Address remaining code review comments from PR #159#165
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #165 +/- ##
==========================================
+ Coverage 94.01% 94.20% +0.19%
==========================================
Files 13 13
Lines 935 915 -20
==========================================
- Hits 879 862 -17
+ Misses 56 53 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: crvernon <3947069+crvernon@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add testing and improvements for plotting utilities
Address remaining code review comments from PR #159
Nov 17, 2025
crvernon
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the remaining code review feedback from PR #159 that wasn't covered by PRs #160-164. Fixes include removing unused parameters, improving test robustness, and adding data validation.
API cleanup
baseparameter fromplot_contour_mapfunction signature and all call sites (utils.py, tests, notebook)ResultsWrapperimport from test fileRobustness improvements
Test improvements
test_empty_data(lines within always-false conditional)test_logit_with_interactionto avoid mutating shared fixture dataassert np.all(np.abs(result.params) > 1e-5)(too strict for legitimate near-zero coefficients)✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.