update descriptions of ClassCreation and ObjectPropertyCreation#83
Open
nlharris wants to merge 2 commits intoINCATools:mainfrom
Open
update descriptions of ClassCreation and ObjectPropertyCreation#83nlharris wants to merge 2 commits intoINCATools:mainfrom
nlharris wants to merge 2 commits intoINCATools:mainfrom
Conversation
Updating ClassCreation description as per @cmungall's suggestion. I guessed at how to update the description for ObjectPropertyCreation; not sure I got it right. Fixed a few minor typos I noticed. BTW, I do not understand these comments (which appeared twice starting at line 928): - if a node obsoletion C, C about N1, and C has direct replacement N2, and there exists an edge with an edge property referencing N1, it is possible to replace with N2 - if a node obsoletion C C about N1, and C has direct replacement N2, then N1 IAO:0100001 N2 (Mostly I don't understand "C about N1". Should "about" be some other word?)
I didn't realize that was a syntax error
Contributor
Author
|
I fixed the syntax error that was making a test fail - how do I get it to rerun the checks? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating ClassCreation description as per @cmungall's suggestion. I guessed at how to update the description for ObjectPropertyCreation; not sure I got it right.
Fixed a few minor typos I noticed.
BTW, I do not understand these comments (which appeared twice starting at line 928):
(Mostly I don't understand "C about N1". Should "about" be some other word?)