Check the ID range file when running the tests.#1178
Merged
Conversation
Make `validate_idranges` a dependency of the `test` target, so the ID range file is systematically checked for errors as part of the standard test suite. closes #211
matentzn
approved these changes
Feb 15, 2025
Contributor
matentzn
left a comment
matentzn
left a comment
There was a problem hiding this comment.
I am a bit worried many ontologies have malformed id ranges.. will you help me a bit when the crying users are trickling in?
Contributor
Author
I am hoping that in the past two years, the support for ID range files in Protégé 5.6 has given enough incentive to ontology maintainers to fix their files (since Protégé cannot use an invalid ID range file). But yeah, we know that some ontologies (e.g. GO) have kept an invalid ID range file for years, and it would not be surprising that some of them never got to fix it.
Sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
validate_idrangesa dependency of thetesttarget, so the ID range file is systematically checked for errors as part of the standard test suite.closes #211