Merged
Conversation
Now that Ammonite is no longer bundled in the ODKLite image, the odk-info.sh script needs to check whether Ammonite is present before attempting to display its version, otherwise it would fail on ODKLite. While we are at it, we update the script to also display the version of Scala-CLI and SSSOM-CLI.
matentzn
reviewed
Feb 20, 2025
Contributor
matentzn
left a comment
matentzn
left a comment
There was a problem hiding this comment.
Thanks, I am a bit stretched this week hence I am a bit delayed in reviewing stuff, much appreciated!
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that Ammonite is no longer bundled in the ODKLite image, the
odk-info.shscript needs to check whether Ammonite is present before attempting to display its version, otherwise it would fail on ODKLite.While we are at it, we update the script to also display the version of Scala-CLI and SSSOM-CLI.