Do not fail for a missing idranges file.#1195
Merged
Conversation
We now check the validity of the -idranges.owl file as part of the routine QC checks. But a project may very well decide that they do _not_ need such a file (if they have their own way of allocating IDs), and in that case they may prefer to remove the file that was generated by the ODK seeding process rather than keeping a useless file around. The absence of an ID range file should not cause a QC failure. If the file is present, then it must be valid, but its absence can be silently ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now check the validity of the -idranges.owl file as part of the routine QC checks.
But a project may very well decide that they do not need such a file (if they have their own way of allocating IDs), and in that case they may prefer to remove the file that was generated by the ODK seeding process rather than keeping a useless file around.
The absence of an ID range file should not cause a QC failure. If the file is present, then it must be valid, but its absence can be silently ignored.