Do not ignore module-level SLME parameters.#1205
Merged
Conversation
Declare the module-level `module_type_slme` and `slme_individuals` options to be None by default. This way, we can detect whether those options have been explicitly set for a given individual module, and if so, use their values instead of using the values from the group level. Then, we can detect whether the SLME type of an individual module is different from the group-level SLME type, and make sure we generate a specific rule for that module in that case. closes #1204
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way the module-level
module_type_slmeandslme_individualsoptions are handled.Specifically, we declare the module-level
module_type_slmeandslme_individualsoptions to beNoneby default.This way, we can detect whether those options have been explicitly set for a given individual module, and if so, use their values instead of using the values from the group level. Otherwise, we set them to the group-level values.
Then, we can detect whether the SLME type of an individual module is different from the group-level SLME type, and make sure we generate a specific rule for that module in that case (fixing #1204 in the process).
closes #1204