Feat issue 2 order of operations #154
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
Improved the reporting of the "order of operations" during preprocessing. Previously, this was an open-ended text area. Per issue discussion (and "future goal" comments), this has been converted to a multi-select list of standard steps, with an "Other" option for complex procedures.
Changes:
Modified
schemas/artemis/activities/preprocessing/items/preprocessing_order.jsonld
: Changed input type to select (multiple) and added choices (Filtering, Downsampling, Re-referencing, Artifact Removal, Epoching, Baseline Correction, Other).
Added
schemas/artemis/activities/preprocessing/items/preprocessing_order_other.jsonld
: New text area for describing unlisted steps (visible only when "Other" is selected).
Updated
schemas/artemis/activities/preprocessing/preprocessing_schema.jsonld
: Added the new item to the order and defined visibility logic.
Verification:
Verified JSON-LD structure and isVis logic (preprocessing_order.includes(6)).