MAINT changed "besides" to "additionally" for better phrasing in hyperparameter tuning takeaway#804
Merged
ArturoAmorQ merged 2 commits intoINRIA:mainfrom Mar 17, 2025
Merged
Conversation
ArturoAmorQ
reviewed
Mar 7, 2025
Collaborator
ArturoAmorQ
left a comment
ArturoAmorQ
left a comment
There was a problem hiding this comment.
Thanks for the PR @SebastienMelo! Here are a couple of suggestions of more in-depth rewording.
Comment on lines
11
to
13
| - A grid-search is expensive and does not scale when the number of | ||
| hyperparameters to optimize increase. Besides, the combination are sampled | ||
| hyperparameters to optimize increase. Additionally, the combination are sampled | ||
| only on a regular grid. |
Collaborator
There was a problem hiding this comment.
This whole paragraph can be improved to avoid a possible confusion with mathematical scaling. How about something in the line of:
- A grid-search can be computationally expensive and becomes less attractive as
the number of hyperparameters to explore increases. Moreover, the combinations
are sampled on a fixed, regular grid.
Comment on lines
14
to
16
| - A randomized-search allows a search with a fixed budget even with an | ||
| increasing number of hyperparameters. Besides, the combination are sampled | ||
| increasing number of hyperparameters. Additionally, the combination are sampled | ||
| on a non-regular grid. |
Collaborator
There was a problem hiding this comment.
- A randomized-search allows exploring within a fixed budget, even as the number
of hyperparameters increases. In this case, combinations can be sampled either
on a regular grid or from a given distribution.
ArturoAmorQ
approved these changes
Mar 17, 2025
Collaborator
|
Thanks @SebastienMelo, merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by this question in the forum, improved the phrasing of the takeaway in the hyperpameter tuning module.