-
Notifications
You must be signed in to change notification settings - Fork 9
Update BidsDatasetBuilder, CreateFile and template_agnostic_files content to go towards a bids-valid output dataset #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@dumaatravaie Here is a first important update on the previous code... We should meet before you start reviewing so that I can explain to you what I did and what should be tested... |
|
Sure, we can have a meeting to discuss about this .. |
|
Hello @dumaatravaie ! I've created a copy of the experiment for you to test all this... There is only one experiment, which is enough! Here is some info:
|
|
Thaks @SylvainTakerkart , i will test the installation and let you know .. |
|
Hello @SylvainTakerkart , and it works, the code runs without error. This may be one of the solution for $DATA_DIR parameter as we discussed. Have a nice weekend |
ok, thanks! |
The aim of this PR: with the existing code (BidsDatasetBuilder) and our current example data available in eLab, make minimal changes so that the output dataset gets validated by the BIDS Validator...
For now, some changes are temporary-hacks, others are possibly long-term improvements...
Temporary hacks:
Definitive changes / improvements:
What remains to be done: generate the proper content of the template (i.e default) files (present in 'template_agnostic_files') so that the content of all the top-level bids metadata files can be validated!