You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello this PR add necessary changes for use of Imagemagick V7 with backward compatibility to V6. That way KiDiff can be used on newer versions of various distros and also on older.
Second commit introduce small check for availability of at least one of three fonts as helvetica was not available on my machine.
Also dropping Python 3.5 (EoL 2020) support could introduce f-string and make some parts of code more readable. Let me know if it would be accepted.
Hi @Tony763 !
Thanks for the patch I'll merge it, but I have some problems with the fonts:
The search for fonts looks for ['helvetica', 'Open-Sans-Regular', 'Roboto'], but the font name for 'helvetica' is "Helvetica", so it won't be detected.
If I fix this I see magick fails to use the Helvetica font, some issue with Type 1 fonts?
Also dropping Python 3.5 (EoL 2020) support could introduce f-string and make some parts of code more readable. Let me know if it would be accepted.
About this: There is no point in supporting Python < 3.7, so yes, I'll accept patches that needs >= 3.7
If you do it please send separated patches, i.e. don't mix f-strings patch with other change.
I could not test Helvetica font family as I do not have them on my system, that was why I added other fonts which were listed as similar. Glad it works for you after some small changes.
Regarding f-strings, sure I will make PR just for them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello this PR add necessary changes for use of Imagemagick V7 with backward compatibility to V6. That way KiDiff can be used on newer versions of various distros and also on older.
Second commit introduce small check for availability of at least one of three fonts as
helveticawas not available on my machine.Also dropping Python 3.5 (EoL 2020) support could introduce f-string and make some parts of code more readable. Let me know if it would be accepted.