Skip to content

Conversation

@Rasmus-M-C
Copy link
Collaborator

Added demo video and example file for simul8 usage
Rewrote readme for simul8 usage.
Created csv parser utility, for creating the input files for simul8 simulations.

None of the tests are rewritten for the simul8 agent, currently, hence they are omitted.

@Rasmus-M-C Rasmus-M-C requested a review from marcomelloni July 9, 2025 16:36
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial version of Simul8 should be 0.1.0. There's an inconsistency in the 'Releasing a new version' section of the README.md

@Rasmus-M-C Rasmus-M-C marked this pull request as draft September 2, 2025 08:40
@Rasmus-M-C Rasmus-M-C marked this pull request as ready for review September 26, 2025 06:43
@prasadtalasila
Copy link
Contributor

@Rasmus-M-C The following command is giving error.

$python .\use_simul8_agent.py --api-payload docs/examples/batch-simulation/api/simulation_batch.yaml.example
Traceback (most recent call last):
  File "C:\Users\foo\git\simulation-bridge\agents\simul8\simul8_agent\resources\use_simul8_agent.py", line 204, in <module>
    client = SimpleUsageSimul8Agent(
             ^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\foo\git\simulation-bridge\agents\simul8\simul8_agent\resources\use_simul8_agent.py", line 52, in __init__
    self.connection = pika.BlockingConnection(
                      ^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\foo\AppData\Local\pypoetry\Cache\virtualenvs\simul8-agent-qKz0Vxb2-py3.12\Lib\site-packages\pika\adapters\blocking_connection.py", line 360, in __init__
Exception in thread Thread-1 (start_listener):
Traceback (most recent call last):
    self._impl = self._create_connection(parameters, _impl_class)
  File "C:\Python312\Lib\threading.py", line 1073, in _bootstrap_inner
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\foo\AppData\Local\pypoetry\Cache\virtualenvs\simul8-agent-qKz0Vxb2-py3.12\Lib\site-packages\pika\adapters\blocking_connection.py", line 451, in _create_connection
    self.run()
  File "C:\Python312\Lib\threading.py", line 1010, in run
    raise self._reap_last_connection_workflow_error(error)
pika.exceptions.IncompatibleProtocolError: StreamLostError: ('Transport indicated EOF',)

The RabbitMQ credentials are correct. I have checked the connectivity using a simple RabbitMQ client program and also from simul8_agent. The simul8 agent connects to the broker successfully.

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 40 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@c211204). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...s/simul8/simul8_agent/src/core/simul8_simulator.py 88.66% 28 Missing ⚠️
agents/simul8/simul8_agent/src/utils/csv_parser.py 89.38% 12 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage        ?   88.88%           
=======================================
  Files           ?        2           
  Lines           ?      360           
  Branches        ?        0           
=======================================
  Hits            ?      320           
  Misses          ?       40           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
41.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@prasadtalasila prasadtalasila merged commit 0fa417b into main Oct 31, 2025
3 of 4 checks passed
@prasadtalasila prasadtalasila deleted the feature/simul8_agent branch November 13, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants