Fix/time kind spice api #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes time frame handling in the SPICE API by ensuring consistent time conversions and adds UTC-based ephemeris testing. The changes address potential time frame inconsistencies in launch window calculations and expand test coverage for UTC time frame operations.
- Updates version numbers to 6.5.1 for the main library and 0.6.5.1 for the CLI
- Fixes time frame conversion consistency in launch window calculations by enforcing TDB usage
- Adds comprehensive test coverage for UTC-based ephemeris computations
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| IO.Astrodynamics.nuspec | Version bump from 6.5.0 to 6.5.1 |
| IO.Astrodynamics.CLI.csproj | Version bump from 0.6.5.0 to 0.6.5.1 |
| API.cs | Fixes time frame conversion to consistently use TDB in launch window calculations |
| CelestialBodyTests.cs | Adds test for ephemeris retrieval using UTC time frames |
| APITest.cs | Adds comprehensive test for ephemeris reading with UTC time frames and null argument validation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to the
IO.Astrodynamicsproject, including version bumps, new test cases for UTC-based ephemeris computations, and modifications to ensure consistency in time frame conversions. Below is a summary of the most important changes:Version Updates:
IO.Astrodynamics.CLI.csprojfrom0.6.5.0to0.6.5.1to reflect new changes.IO.Astrodynamics.nuspecfrom6.5.0to6.5.1.New Test Cases:
ReadEphemerisUTCtest inAPITest.csto validate ephemeris computations with UTC time frames, including assertions for state vectors and null argument exceptions.GetEphemerisUTCtest inCelestialBodyTests.csto verify ephemeris retrieval for Earth using UTC time frames.Time Frame Conversion Enhancements:
FindLaunchWindowsinAPI.csto enforce consistent use of TDB (Barycentric Dynamical Time) in time frame conversions for launch window calculations.