Skip to content

Conversation

@Arsalanulhaq
Copy link

@Arsalanulhaq Arsalanulhaq commented Dec 23, 2025

This pull request updates the user creation dialog to prevent assigning the "admin" group as a sub-admin group, improving group management logic and user experience.

User group selection improvements:

  • The group selection dropdown for sub-admin assignment now uses the new availableSubAdminGroups computed property, which filters out the "admin" group so it cannot be assigned as a sub-admin group.
  • Added the availableSubAdminGroups computed property to exclude the "admin" group from the list of available groups for sub-admin assignment.

Related:

TODO

Checklist

@Arsalanulhaq Arsalanulhaq force-pushed the as/dev/prevent_admin_group_subadmin branch from a0f5e70 to 23af481 Compare December 23, 2025 10:05
@Arsalanulhaq Arsalanulhaq changed the title IONOS(NewUserDialog): update group options to exclude admin from sub-… IONOS(NewUserDialog): update group selection to prevent admin group from being assigned as subadmin Dec 24, 2025
@Arsalanulhaq Arsalanulhaq requested a review from Copilot December 29, 2025 10:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prevents the "admin" group from being assigned as a sub-admin group during user creation, addressing a logical inconsistency in group management. The change ensures that when creating a new user, the "Set account as admin for..." dropdown only displays groups that are valid for sub-admin assignment.

Key changes:

  • Added a new computed property availableSubAdminGroups that filters out the "admin" group from the available groups list
  • Updated the sub-admin group selection dropdown to use the new filtered list instead of all available groups

@printminion-co printminion-co changed the base branch from ionos-donot-merge to rc/nsw-2 January 5, 2026 12:09
@printminion-co printminion-co merged commit aaf5824 into rc/nsw-2 Jan 5, 2026
11 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants