refactor(ci): add safety guards and consolidate directory removal in cache restoration

[Copilot]

• Resolves: ci: fix pipelines on first run with apps-externa submodule change  #228

Summary

Addresses review feedback on the cache restoration fix by adding safety guards to prevent accidental deletion and consolidating duplicate logic.

Changes:

• Safety guards for rm -rf: Validates path is non-empty, not root, and under $GITHUB_WORKSPACE/(apps-external|apps)/ before deletion
• Consolidated logic: Extracted directory removal into safe_remove_app_dir() function, eliminating duplication between JFrog and GitHub cache paths
• Code quality: Removed trailing whitespace, improved regex pattern clarity

# Function to safely remove app directory before cache restoration
safe_remove_app_dir() {
  local app_path="$1"
  
  # Safety checks before removing directory
  if [ -z "$app_path" ]; then
    echo "❌ Error: app_path is empty, refusing to delete"
    exit 1
  fi
  
  if [ "$app_path" = "/" ]; then
    echo "❌ Error: app_path is root directory, refusing to delete"
    exit 1
  fi
  
  # Verify path is under expected workspace directories
  local pattern="^${GITHUB_WORKSPACE}/(apps-external|apps)/"
  if [[ ! "$app_path" =~ $pattern ]]; then
    echo "❌ Error: app_path '$app_path' is not under expected workspace directory"
    exit 1
  fi
  
  # Remove directory if it exists
  if [ -d "$app_path" ]; then
    echo "🗑️  Removing existing directory: $app_path"
    rm -rf "$app_path"
  fi
}

TODO

• Add safety guards to directory removal
• Extract duplicate logic into function
• Remove whitespace issues

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.