Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
137 changes: 137 additions & 0 deletions .github/workflows/promote-artifact.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,137 @@
name: Promote QA-approved artifacts to stable branch

# - Takes a commit SHA as input
# - Fast-forward merges it to ionos-stable (no new commits)
# - Promotes the exact artifact from Artifactory (no rebuild)

on:
workflow_dispatch:
inputs:
sha:
description: 'Commit SHA to promote from ionos-dev to ionos-stable and copy artifacts for'
required: true
type: string
env:
SHA: ${{ inputs.sha }}
ARTIFACTORY_REPOSITORY_SNAPSHOT: ionos-productivity-ncwserver-snapshot
Comment on lines +10 to +16
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inputs.sha is accepted as an arbitrary git revision (e.g., a ref like origin/ionos-dev or HEAD), not strictly a commit hash. That can promote a moving target or an unintended commit. Validate the input to only allow a full 40-hex commit SHA (and derive SHORT_SHA=${SHA:0:7} from it if needed for artifact paths).

Copilot uses AI. Check for mistakes.
ARTIFACTORY_REPOSITORY_RELEASE: ionos-productivity-ncwserver-release

permissions:
contents: write

concurrency:
group: promote-artifact
cancel-in-progress: false
jobs:
promote-git:
# Fast-forward merge SHA from ionos-dev into ionos-stable
# (This ensures commit-hash is identical)
runs-on: ubuntu-latest
steps:
- name: Checkout server
id: checkout_server
uses: actions/checkout@v5
with:
fetch-depth: 0

- name: Verify SHA is in ionos-dev
id: verify_sha
run: |
set -euo pipefail
git fetch origin ionos-dev ionos-stable
git checkout -B ionos-stable origin/ionos-stable
if ! git rev-parse --verify "$SHA^{commit}" >/dev/null 2>&1; then
echo "Error: SHA is not a valid commit: $SHA"
exit 1
fi
# verify SHA is on ionos-dev
if ! git merge-base --is-ancestor "$SHA" origin/ionos-dev; then
echo "Error: SHA does not exist on ionos-dev: $SHA"
exit 1
fi

- name: Fast-forward merge
id: ff_merge
run: |
set -euo pipefail
# Merge will fail if not possible
if ! git merge --ff-only "$SHA"; then
echo "Fast-forward merge not possible"
exit 1
fi

# Ensure that the resulting HEAD is exactly the requested SHA.
# This prevents the case where SHA is behind ionos-stable and
# 'git merge --ff-only' reports "Already up to date" without
# moving the branch to $SHA.
HEAD_SHA="$(git rev-parse HEAD)"
if [ "$HEAD_SHA" != "$SHA" ]; then
echo "Error: After merge, HEAD ($HEAD_SHA) does not match requested SHA ($SHA)."
echo "Refusing to push ionos-stable or promote artifacts for a mismatched commit."
exit 1
fi

git push origin HEAD:ionos-stable
promote-artifact:
# Copy specified artifact to the release repo -> No rebuild
# (ionos-productivity-ncwserver-release)
needs: promote-git
runs-on: ubuntu-latest
steps:
Comment on lines +76 to +80
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Job ordering makes the git fast-forward/push happen before the Artifactory copy (promote-artifact depends on promote-git). If the artifact copy fails (missing artifact, JFrog outage, permission issue), ionos-stable will already have advanced, leaving the stable branch and release artifacts out of sync. Consider promoting/verifying artifacts first and only pushing ionos-stable after the copy succeeds (or otherwise enforce atomicity).

Copilot uses AI. Check for mistakes.
- name: Setup JFrog CLI
id: setup_jf
uses: jfrog/setup-jfrog-cli@7c95feb32008765e1b4e626b078dfd897c4340ad # v4.4.1
env:
JF_URL: ${{ secrets.JF_ARTIFACTORY_URL }}
JF_USER: ${{ secrets.JF_ARTIFACTORY_USER }}
JF_ACCESS_TOKEN: ${{ secrets.JF_ACCESS_TOKEN }}

- name: Ping the JF server
run: |
# Ping the server
jf rt ping

- name: Find artifacts matching the SHA
id: find_artifact
run: |
# Expected Artifactory layout:
# ionos-productivity-ncwserver-snapshot/
# dev/<branch-name>/$SHA/<artifact-files>
#
# We search for a single .tar.gz artifact for the given SHA and
# derive its containing directory. This avoids using wildcards
# for the branch component when copying to the release repo.
set -e
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step uses set -e but relies on pipelines like echo "$SEARCH_RESULT" | jq ...; without set -o pipefail (and ideally -u), jq parse failures can be ignored and lead to misleading behavior downstream. Switch to set -euo pipefail (consistent with earlier steps) so JSON parsing errors fail the job.

Suggested change
set -e
set -euo pipefail

Copilot uses AI. Check for mistakes.
SEARCH_RESULT=$(jf rt search --format=json --limit=2 "${{ env.ARTIFACTORY_REPOSITORY_SNAPSHOT }}/dev/*/$SHA/*.tar.gz")
MATCH_COUNT=$(echo "$SEARCH_RESULT" | jq '.results | length')

if [ "$MATCH_COUNT" -eq 0 ]; then
echo "No artifact with SHA $SHA found."
exit 1
fi

if [ "$MATCH_COUNT" -gt 1 ]; then
echo "Multiple artifacts found for SHA $SHA; expected exactly one."
echo "$SEARCH_RESULT"
exit 1
fi

ARTIFACT_REPO=$(echo "$SEARCH_RESULT" | jq -r '.results[0].repo')
ARTIFACT_PATH=$(echo "$SEARCH_RESULT" | jq -r '.results[0].path')
# Derive the directory that contains all artifacts for this SHA
ARTIFACT_DIR_PATH=$(dirname "$ARTIFACT_PATH")
ARTIFACT_DIR="$ARTIFACT_REPO/$ARTIFACT_DIR_PATH"

echo "Using artifact directory: $ARTIFACT_DIR"
# Expose the directory as a step output for the copy step
echo "artifact_dir=$ARTIFACT_DIR" >> "$GITHUB_OUTPUT"
- name: Copy artifact to target
id: copy_artifact
run: |
jf rt copy \
"${{ steps.find_artifact.outputs.artifact_dir }}/*" \
"${{ env.ARTIFACTORY_REPOSITORY_RELEASE }}/stable/${SHA}/"

- name: Confirm promoted artifacts
run: |
jf rt search --format=table "${{ env.ARTIFACTORY_REPOSITORY_RELEASE }}/stable/${SHA}/*"
Comment on lines +97 to +137
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Artifactory search pattern here (.../dev/*/$SHA/*.tar.gz) doesn’t match the layout used by .github/workflows/build-artifact.yml when uploading the workspace artifact (stored as nc-workspace.zip under <stage>/ncw-<ncVersion>/<shortSha>/...). With the current path/extension and use of full SHA, this step will fail to find the QA-approved build. Update the search/copy logic to follow the actual upload structure (including using the short SHA if that’s what the upload uses).

Suggested change
# Expected Artifactory layout:
# ionos-productivity-ncwserver-snapshot/
# dev/<branch-name>/$SHA/<artifact-files>
#
# We search for a single .tar.gz artifact for the given SHA and
# derive its containing directory. This avoids using wildcards
# for the branch component when copying to the release repo.
set -e
SEARCH_RESULT=$(jf rt search --format=json --limit=2 "${{ env.ARTIFACTORY_REPOSITORY_SNAPSHOT }}/dev/*/$SHA/*.tar.gz")
MATCH_COUNT=$(echo "$SEARCH_RESULT" | jq '.results | length')
if [ "$MATCH_COUNT" -eq 0 ]; then
echo "No artifact with SHA $SHA found."
exit 1
fi
if [ "$MATCH_COUNT" -gt 1 ]; then
echo "Multiple artifacts found for SHA $SHA; expected exactly one."
echo "$SEARCH_RESULT"
exit 1
fi
ARTIFACT_REPO=$(echo "$SEARCH_RESULT" | jq -r '.results[0].repo')
ARTIFACT_PATH=$(echo "$SEARCH_RESULT" | jq -r '.results[0].path')
# Derive the directory that contains all artifacts for this SHA
ARTIFACT_DIR_PATH=$(dirname "$ARTIFACT_PATH")
ARTIFACT_DIR="$ARTIFACT_REPO/$ARTIFACT_DIR_PATH"
echo "Using artifact directory: $ARTIFACT_DIR"
# Expose the directory as a step output for the copy step
echo "artifact_dir=$ARTIFACT_DIR" >> "$GITHUB_OUTPUT"
- name: Copy artifact to target
id: copy_artifact
run: |
jf rt copy \
"${{ steps.find_artifact.outputs.artifact_dir }}/*" \
"${{ env.ARTIFACTORY_REPOSITORY_RELEASE }}/stable/${SHA}/"
- name: Confirm promoted artifacts
run: |
jf rt search --format=table "${{ env.ARTIFACTORY_REPOSITORY_RELEASE }}/stable/${SHA}/*"
# Expected Artifactory layout (from build-artifact.yml):
# ionos-productivity-ncwserver-snapshot/
# <stage>/ncw-<ncVersion>/<shortSha>/nc-workspace.zip
#
# We derive the short SHA from the full SHA provided as input,
# search for the nc-workspace.zip artifact for that short SHA,
# and then derive its containing directory. This avoids using
# wildcards for the version component when copying to the release repo.
set -e
SHORT_SHA=${SHA:0:7}
SEARCH_RESULT=$(jf rt search --format=json --limit=2 "${{ env.ARTIFACTORY_REPOSITORY_SNAPSHOT }}/*/ncw-*/*${SHORT_SHA}/nc-workspace.zip")
MATCH_COUNT=$(echo "$SEARCH_RESULT" | jq '.results | length')
if [ "$MATCH_COUNT" -eq 0 ]; then
echo "No artifact with short SHA $SHORT_SHA (from $SHA) found."
exit 1
fi
if [ "$MATCH_COUNT" -gt 1 ]; then
echo "Multiple artifacts found for short SHA $SHORT_SHA (from $SHA); expected exactly one."
echo "$SEARCH_RESULT"
exit 1
fi
ARTIFACT_REPO=$(echo "$SEARCH_RESULT" | jq -r '.results[0].repo')
ARTIFACT_PATH=$(echo "$SEARCH_RESULT" | jq -r '.results[0].path')
# Derive the directory that contains all artifacts for this short SHA
ARTIFACT_DIR_PATH=$(dirname "$ARTIFACT_PATH")
ARTIFACT_DIR="$ARTIFACT_REPO/$ARTIFACT_DIR_PATH"
echo "Using artifact directory: $ARTIFACT_DIR"
# Expose the directory and short SHA as step outputs for subsequent steps
echo "artifact_dir=$ARTIFACT_DIR" >> "$GITHUB_OUTPUT"
echo "short_sha=$SHORT_SHA" >> "$GITHUB_OUTPUT"
- name: Copy artifact to target
id: copy_artifact
run: |
jf rt copy \
"${{ steps.find_artifact.outputs.artifact_dir }}/*" \
"${{ env.ARTIFACTORY_REPOSITORY_RELEASE }}/stable/${{ steps.find_artifact.outputs.short_sha }}/"
- name: Confirm promoted artifacts
run: |
jf rt search --format=table "${{ env.ARTIFACTORY_REPOSITORY_RELEASE }}/stable/${{ steps.find_artifact.outputs.short_sha }}/*"

Copilot uses AI. Check for mistakes.
Loading