feat(cli): Add styled splash screen with ASCII art logo#22
feat(cli): Add styled splash screen with ASCII art logo#22MarvelNwachukwu merged 2 commits intomainfrom
Conversation
Replace plain-text help with a styled splash screen matching the ADK-TS CLI aesthetic. Shows magenta ASCII art "ADK CLAW" logo, tagline, version, commands, and links. Running with no args now shows the splash instead of auto-running init.
Summary of ChangesHello @MarvelNwachukwu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly upgrades the command-line interface's initial user interaction by introducing a rich, styled splash screen. This change improves the aesthetic appeal and clarity of the CLI's entry point, making it more user-friendly and consistent with the project's branding. It refactors how help and version information are presented, centralizing display logic and enhancing the overall first impression for users. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request successfully introduces a styled splash screen for the CLI, enhancing the user experience and consolidating help and version output. The change in default behavior to display the splash screen instead of auto-running init is a clear improvement, aligning with common CLI patterns. The new splash screen provides a more engaging and informative initial interaction for users. My feedback primarily focuses on improving maintainability by centralizing the version number definition to prevent potential inconsistencies.
src/cli/index.ts
Outdated
| const args = process.argv.slice(2); | ||
| const command = args[0]; | ||
|
|
||
| const VERSION = "0.1.0"; |
There was a problem hiding this comment.
Hardcoding the VERSION constant here can lead to inconsistencies if the project's version in package.json is updated but this file is not. It's best practice to derive the version directly from package.json to maintain a single source of truth and ensure all parts of the application reflect the correct version.
import { createRequire } from 'module';
const require = createRequire(import.meta.url);
const { version: CLI_VERSION } = require('../../package.json');| case "--version": | ||
| case "-v": | ||
| printVersion(); | ||
| console.log(`adk-claw v${VERSION}`); |
Summary
adk-clawwith no args now shows the splash instead of auto-runninginit(adk-claw initstill works)Test plan
pnpm dev:cli(no args) — should display splash screenpnpm dev:cli --help— should display splash screenpnpm dev:cli init— should run setup wizard as beforepnpm dev:cli --version— should print versionpnpm build && pnpm cli— verify built mode works