Skip to content

Fix Telegram multi-line message truncation #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarvelNwachukwu merged 2 commits into from
Mar 18, 2026
Merged

Fix Telegram multi-line message truncation #26

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c264fcd
fix(telegram): preserve multi-line messages in MCP Telegram parser
MarvelNwachukwu Mar 18, 2026
e00b5ba
refactor: use indexed for-loop in parseTelegramMessage
MarvelNwachukwu Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/services/TelegramService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,12 @@ function parseTelegramMessage(content: string): {
} else if (trimmed.startsWith("chat_id:")) {
chatId = trimmed.replace("chat_id:", "").trim();
} else if (trimmed.startsWith("content:")) {
messageText = trimmed.replace("content:", "").trim();
const contentIndex = lines.indexOf(line);
const firstLine = trimmed.replace("content:", "").trim();
const remainingLines = lines.slice(contentIndex + 1);
messageText = [firstLine, ...remainingLines].join("\n").trim();
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using lines.indexOf(line) inside this loop can be inefficient, as it performs a search on each iteration where the content: line is checked. This could lead to O(n^2) complexity in a worst-case scenario. It might also be brittle if a previous line in the message has the exact same content as the content: line.

A more robust and efficient approach would be to use a for loop that provides an index, which avoids the need for indexOf.

Example:

for (let i = 0; i < lines.length; i++) {
    const line = lines[i];
    const trimmed = line.trim();
    // ... other if/else if branches
    if (trimmed.startsWith("content:")) {
        const firstLine = trimmed.replace("content:", "").trim();
        const remainingLines = lines.slice(i + 1);
        messageText = [firstLine, ...remainingLines].join('\n').trim();
        foundContent = true;
        break;
    }
}

This would require changing the for...of loop on line 44. While this is outside the current diff, it's a recommended improvement for robustness and performance.

foundContent = true;
break;
}
}

Expand Down
Loading