Skip to content

Testing#7

Merged
AshakaE merged 7 commits intomainfrom
testing
Jul 3, 2025
Merged

Testing#7
AshakaE merged 7 commits intomainfrom
testing

Conversation

@AshakaE
Copy link
Copy Markdown
Contributor

@AshakaE AshakaE commented Jul 2, 2025

Basic testing of services
closes #315

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 2, 2025

⚠️ No Changeset found

Latest commit: 26dfa3b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@AshakaE AshakaE requested a review from GPSxtreme July 2, 2025 11:34
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @AshakaE, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the project's stability and maintainability by introducing a comprehensive unit testing framework. It sets up the necessary tooling for efficient testing of TypeScript services, provides initial test coverage for key service components, and refines linting rules to improve code readability and reduce noise.

Highlights

  • Unit Testing Setup: Implemented Jest and ts-jest to establish a robust unit testing framework for the project's TypeScript services.
  • Service Test Coverage: Added dedicated test suites for GetUserCreatedWikisService, GetUserEditedWikisService, GetUserWikiActivitiesService, and GetWikiService, ensuring core functionalities and error handling are validated.
  • Build Tooling Configuration: Introduced babel.config.js for TypeScript transpilation during testing and updated package.json with necessary testing dependencies and a test script.
  • Linting Rule Refinement: Adjusted biome.json to disable the noExplicitAny linting rule, allowing for the removal of numerous biome-ignore comments and simplifying code.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Jest tests, improving project stability and revealing bugs. Configuration changes in biome.json and tsconfig.json weaken type-checking and linting. A test case in src/tests/get-user-wiki-activities.test.ts needs correction. Addressing these points will strengthen the PR.

@AshakaE AshakaE merged commit 33fe304 into main Jul 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant