Share Collection and Share Dataset features #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-saracca
added
Size: 3
Contributor
Author
Member
|
@g-saracca looks good to me! Modern icons! |
ChengShi-1
requested changes
Nov 23, 2024
Contributor
ChengShi-1
left a comment
ChengShi-1
left a comment
There was a problem hiding this comment.
Great job~ I left some comments here may need changes.
src/sections/dataset/dataset-action-buttons/DatasetActionButtons.tsx
Outdated
Show resolved
Hide resolved
tests/component/sections/dataset/dataset-action-buttons/DatasetActionButtons.spec.tsx
Outdated
Show resolved
Hide resolved
tests/component/sections/shared/social-share-modal/SocialShareModal.spec.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@ChengShi-1 all the requested changes have been addressed 👍🏼 , thanks! |
cmbz
added
FY25 Sprint 12
Contributor
|
Ran into a bummer while testing this. Got error page when I'm trying to add a new dataset.
Issue: Got error page after clicking on add data
maybe local env issue from my end? |
Contributor
Author
|
Hi @ofahimIQSS let me update this branch with latest from develop so you can try again 👍🏼 |
Contributor
Author
|
@ofahimIQSS branch updated, its a weird error and not related to the changes applied in this feature but try again now and let me know, thanks! |
ChengShi-1
approved these changes
Dec 17, 2024
Contributor
|
Verified in local - no issues found. Merging PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Replicates the Share feature on the Collection Page and Dataset Page, supporting the same sharing channel options as in JSF.
Same modal component
SocialShareModalit's used for both pages.Which issue(s) this PR closes:
Suggestions on how to test this:
Click the share buttons and check that the redirections are correct.
Unlike the JSF version, the links do not open in a popup but open in a new tab.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes.
Collection Page
Dataset Page
Is there a release notes update needed for this change?:
No
Additional documentation:
No