Skip to content

Comments

remove ```bash to fix links lower down#597

Merged
ofahimIQSS merged 2 commits intodevelopfrom
fix-links
Feb 6, 2025
Merged

remove ```bash to fix links lower down#597
ofahimIQSS merged 2 commits intodevelopfrom
fix-links

Conversation

@pdurbin
Copy link
Member

@pdurbin pdurbin commented Feb 5, 2025

Before: links unclickable, odd formatting

Screenshot 2025-02-05 at 10 17 34 AM

After

Screenshot 2025-02-05 at 10 18 17 AM


If you are running the script for the first time, it may take a while, since npm has to install all project dependencies.
This can also happen if you added new dependencies to `package.json`, or used the _uninstall_ script to remove current
project files and shut down any running containers.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably also remove the <br> below. 🤷

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I like that extra space it gives from the other section, but as you see fit 👍🏼

@coveralls
Copy link

coveralls commented Feb 5, 2025

Coverage Status

coverage: 97.466% (-0.02%) from 97.481%
when pulling 20c522e on fix-links
into 692283b on develop.

@g-saracca g-saracca added documentation Changes only affect the documentation GREI Re-arch GREI re-architecture-related labels Feb 5, 2025
@g-saracca g-saracca self-assigned this Feb 5, 2025
g-saracca
g-saracca previously approved these changes Feb 5, 2025
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving looks good, the only weird thing is why prettier check action is failing, I made the same change on my local end and it doesn't show me any error.

@ofahimIQSS ofahimIQSS self-assigned this Feb 5, 2025
@ofahimIQSS
Copy link
Contributor

ofahimIQSS commented Feb 5, 2025

lint / lint (pull_request) & lint / lint (push) are failing on this.

Edit: test / component (push) failing as well --- 2nd edit, after rerunning it, looks like this passed.

@g-saracca
Copy link
Contributor

@pdurbin, I pushed the fix that was making the prettier check action to fail. Please check again if everything keeps looking good and I will approve again.

@pdurbin
Copy link
Member Author

pdurbin commented Feb 6, 2025

@g-saracca looks good to me! Thanks!

@g-saracca g-saracca removed their assignment Feb 6, 2025
@g-saracca
Copy link
Contributor

@ofahimIQSS, ready for QA

@ofahimIQSS
Copy link
Contributor

Good to go - merging PR

@ofahimIQSS ofahimIQSS merged commit a5f2998 into develop Feb 6, 2025
10 of 14 checks passed
@ofahimIQSS ofahimIQSS deleted the fix-links branch February 6, 2025 16:03
@ofahimIQSS ofahimIQSS removed their assignment Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Changes only affect the documentation GREI Re-arch GREI re-architecture-related

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

4 participants