Delete Collection - SPA integration#605
Merged
ofahimIQSS merged 17 commits intodevelopfrom Mar 21, 2025
Merged
Conversation
Contributor
|
@g-saracca there are merge conflicts, can you resolve? |
Contributor
Author
|
@ekraffmiller , they are just js-dataverse package conflicts, I will resolve them after the Delete File SPA Integration is merged if its ok with you, to avoid solving conflicts twice. |
ChengShi-1
reviewed
Feb 27, 2025
Contributor
ChengShi-1
left a comment
There was a problem hiding this comment.
Inspect the code and test the function on the page. Everything great! just a tiny tweak
tests/component/sections/collection/edit-collection-dropdown/EditCollectionDropdown.spec.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@ChengShi-1 change made, thanks! |
ChengShi-1
approved these changes
Feb 27, 2025
Contributor
ChengShi-1
left a comment
There was a problem hiding this comment.
Looks good to me. approve:)
Contributor
Contributor
Author
|
@ChengShi-1 could you approve the UI reviews? |
Contributor
Contributor
|
looks good from my end. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What this PR does / why we need it:
Replicate JSF Delete Collection functionality.
Also added copy labels github action workflow.
Which issue(s) this PR closes:
Suggestions on how to test this:
Step 1: Run the Development Environment
npm i.cd packages/design-system && npm i && npm run build.cd ../../..envfile similar to.env.example, with the variableVITE_DATAVERSE_BACKEND_URL=http://localhost:8000.cd dev-env../run-env.sh unstable.Step 2: Test the feature
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes.


Is there a release notes update needed for this change?:
No.
Additional documentation:
No.