Merged
Conversation
Contributor
Author
|
Solved conflicts and using latest alpha version of js-dataverse |
Contributor
ekraffmiller
left a comment
There was a problem hiding this comment.
Looks good! A couple of comments
src/sections/file/file-action-buttons/edit-file-menu/delete-file-button/DeleteFileButton.tsx
Outdated
Show resolved
Hide resolved
src/sections/file/file-action-buttons/edit-file-menu/delete-file-button/useDeleteFile.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@ekraffmiller all changes applied. Let me know what you think about the |
ekraffmiller
previously approved these changes
Feb 25, 2025
Contributor
ekraffmiller
left a comment
There was a problem hiding this comment.
looks good, approved!
Contributor
|
hello! I see some branch conflicts on this PR. Can you please resolve before I can merge. Thanks! |
Contributor
Author
|
@ekraffmiller could you reapprove? I just merge develop into the branch to solve conflicts 👍🏼 |
ekraffmiller
approved these changes
Feb 26, 2025
Contributor
ekraffmiller
left a comment
There was a problem hiding this comment.
looks good, approved
Contributor
Author
|
All done @ofahimIQSS 👌🏼 |
Contributor
|
PR looking good - merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implements the Delete File option on the Edit File dropdown in the File Page.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Step 1: Run the Development Environment
npm i.cd packages/design-system && npm i && npm run build.cd ../../..envfile similar to.env.example, with the variableVITE_DATAVERSE_BACKEND_URL=http://localhost:8000.cd dev-env../run-env.sh unstable.Step 2: Test the feature
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes.



Is there a release notes update needed for this change?:
Additional documentation: