Skip to content

Comments

Delete File - SPA Integration#606

Merged
ofahimIQSS merged 27 commits intodevelopfrom
feat/590-delete-file
Feb 26, 2025
Merged

Delete File - SPA Integration#606
ofahimIQSS merged 27 commits intodevelopfrom
feat/590-delete-file

Conversation

@g-saracca
Copy link
Contributor

What this PR does / why we need it:

Implements the Delete File option on the Edit File dropdown in the File Page.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

Step 1: Run the Development Environment

  1. Execute npm i.
  2. Navigate with cd packages/design-system && npm i && npm run build.
  3. Return with cd ../../.
  4. Ensure you have a .env file similar to .env.example, with the variable VITE_DATAVERSE_BACKEND_URL=http://localhost:8000.
  5. Navigate with cd dev-env.
  6. Start the environment using ./run-env.sh unstable.
  7. To verify the environment, visit http://localhost:8000 and check your local Dataverse installation.

Step 2: Test the feature

  1. Create a dataset and a file in it.
  2. Go to that file and click on Edit File > Delete. Only one message should appear in the dialog "The file will be deleted after you click on the Delete button.".
  3. Click the Delete button in the dialog, after deletion a success toast should appear and you should be redirected to the parent dataset.
  4. Add a new file to that dataset and then publish the dataset.
  5. Go to that file and click on Edit File > Delete. Two messages should appear in the dialog now.
  • "The file will be deleted after you click on the Delete button."
  • "Files will not be removed from previously published versions of the dataset."
  1. Click the Delete button in the dialog, after deletion a success toast should appear and you should be redirected to the parent dataset.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Yes.
Screen Shot 2025-02-18 at 11 31 22
Screen Shot 2025-02-18 at 11 31 56
Screen Shot 2025-02-18 at 11 31 28

Is there a release notes update needed for this change?:

Additional documentation:

@g-saracca g-saracca added Size: 3 A percentage of a sprint. 2.1 hours. GREI Re-arch GREI re-architecture-related Original size: 3 SPA.Q1.6 Files Page: Files Edit Options FY25 Sprint 16 FY25 Sprint 16 (2025-01-29 - 2025-02-12) FY25 Sprint 17 FY25 Sprint 17 (2025-02-12 - 2025-02-26) labels Feb 18, 2025
@coveralls
Copy link

coveralls commented Feb 18, 2025

Coverage Status

coverage: 97.367% (+0.03%) from 97.342%
when pulling 496d269 on feat/590-delete-file
into 5a2e625 on develop.

@ekraffmiller ekraffmiller self-assigned this Feb 24, 2025
@g-saracca
Copy link
Contributor Author

Solved conflicts and using latest alpha version of js-dataverse

Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple of comments

@g-saracca
Copy link
Contributor Author

@ekraffmiller all changes applied. Let me know what you think about the key prop.
Thanks for the review!

ekraffmiller
ekraffmiller previously approved these changes Feb 25, 2025
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, approved!

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Feb 25, 2025
@ofahimIQSS ofahimIQSS self-assigned this Feb 25, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Feb 25, 2025
@ofahimIQSS
Copy link
Contributor

hello! I see some branch conflicts on this PR. Can you please resolve before I can merge. Thanks!

@g-saracca
Copy link
Contributor Author

@ekraffmiller could you reapprove? I just merge develop into the branch to solve conflicts 👍🏼

Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, approved

@github-project-automation github-project-automation bot moved this from QA ✅ to Ready for QA ⏩ in IQSS Dataverse Project Feb 26, 2025
@g-saracca
Copy link
Contributor Author

All done @ofahimIQSS 👌🏼

@ofahimIQSS
Copy link
Contributor

PR looking good - merging.

@ofahimIQSS ofahimIQSS merged commit fa6299a into develop Feb 26, 2025
14 checks passed
@ofahimIQSS ofahimIQSS deleted the feat/590-delete-file branch February 26, 2025 17:46
@github-project-automation github-project-automation bot moved this from Ready for QA ⏩ to Merged 🚀 in IQSS Dataverse Project Feb 26, 2025
@ofahimIQSS ofahimIQSS removed their assignment Feb 26, 2025
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 16 FY25 Sprint 16 (2025-01-29 - 2025-02-12) FY25 Sprint 17 FY25 Sprint 17 (2025-02-12 - 2025-02-26) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q1.6 Files Page: Files Edit Options

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

File Page: Delete File

4 participants