Skip to content

Comments

604 deaccession dataset#611

Merged
ofahimIQSS merged 29 commits intodevelopfrom
feat/604-deaccession-dataset
Mar 27, 2025
Merged

604 deaccession dataset#611
ofahimIQSS merged 29 commits intodevelopfrom
feat/604-deaccession-dataset

Conversation

@ekraffmiller
Copy link
Contributor

@ekraffmiller ekraffmiller commented Feb 26, 2025

What this PR does / why we need it:

Implements the Deaccession Dataset feature

Which issue(s) this PR closes:

Suggestions on how to test this:

Step 1: Run the Development Environment

Execute npm i.
Navigate with cd packages/design-system && npm i && npm run build.
Return with cd ../../.
Ensure you have a .env file similar to .env.example, with the variable VITE_DATAVERSE_BACKEND_URL=http://localhost:8000.
Navigate with cd dev-env.
Start the environment using ./run-env.sh unstable.
To verify the environment, visit http://localhost:8000/ and check your local Dataverse installation.

Step 2: Test the feature

  1. Create a dataset and publish it
  2. From the Edit Dataset drop down, choose Deaccession Dataset
  3. Fill out the form and click 'Continue'
  4. On the confirm modal, click 'Yes'
  5. The Deaccession should be successful, and the Dataset Page will show that the Dataset has been deaccessioned.
  6. Create another dataset, and publish multiple versions of the Dataset
  7. From the Edit Dataset drop down, choose Deaccession Dataset
  8. Check that all the published versions are displayed
  9. Choose multiple versions and check that they are all deaccessioned.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Replicating these JSF UI Components:
Screenshot 2025-03-07 at 1 15 19 PM
Screenshot 2025-03-07 at 1 14 22 PM
Screenshot 2025-03-07 at 1 15 00 PM

Is there a release notes update needed for this change?:

Additional documentation:

@ekraffmiller ekraffmiller changed the title Feat/604 deaccession dataset 604 deaccession dataset Feb 26, 2025
@coveralls
Copy link

coveralls commented Feb 26, 2025

Coverage Status

coverage: 97.632% (-0.1%) from 97.733%
when pulling 4dfa68c on feat/604-deaccession-dataset
into 3114ec7 on develop.

@ekraffmiller ekraffmiller marked this pull request as ready for review March 7, 2025 18:35
@ekraffmiller ekraffmiller moved this to Ready for Review ⏩ in IQSS Dataverse Project Mar 7, 2025
@ekraffmiller ekraffmiller added FY25 Sprint 18 FY25 Sprint 18 (2025-02-26 - 2025-03-12) SPA.Q1.5 Dataset Page: Deaccession Dataset Size: 10 A percentage of a sprint. 7 hours. Original size: 10 SPA: Dataset page (View) labels Mar 7, 2025
@ekraffmiller ekraffmiller added the GREI Re-arch GREI re-architecture-related label Mar 10, 2025
@ekraffmiller ekraffmiller moved this from Ready for Review ⏩ to In Progress 💻 in IQSS Dataverse Project Mar 10, 2025
@ekraffmiller ekraffmiller moved this from QA ✅ to In Review 🔎 in IQSS Dataverse Project Mar 21, 2025
@ekraffmiller
Copy link
Contributor Author

Hi @ChengShi-1 thanks for your review! I made the requested changes

ChengShi-1
ChengShi-1 previously approved these changes Mar 26, 2025
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! It looks good to me

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Mar 26, 2025
@ChengShi-1
Copy link
Contributor

@ekraffmiller Hi Ellen! there are some conflicts existing. Could you resolve conflicts, and I'll approve again. Thanks!

@ekraffmiller
Copy link
Contributor Author

@ekraffmiller Hi Ellen! there are some conflicts existing. Could you resolve conflicts, and I'll approve again. Thanks!

hi @ChengShi-1 ready for review!

@ChengShi-1 ChengShi-1 self-requested a review March 26, 2025 19:44
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Mar 26, 2025
@ofahimIQSS
Copy link
Contributor

ofahimIQSS commented Mar 27, 2025

tested and no issues found, merging

image
image
image

@ofahimIQSS ofahimIQSS merged commit 668e48f into develop Mar 27, 2025
14 checks passed
@ofahimIQSS ofahimIQSS deleted the feat/604-deaccession-dataset branch March 27, 2025 15:37
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Mar 27, 2025
@ofahimIQSS ofahimIQSS removed their assignment Mar 27, 2025
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 18 FY25 Sprint 18 (2025-02-26 - 2025-03-12) FY25 Sprint 19 FY25 Sprint 19 (2025-03-12 - 2025-03-26) GREI Re-arch GREI re-architecture-related Original size: 10 Size: 10 A percentage of a sprint. 7 hours. SPA: Dataset page (View) SPA.Q1.5 Dataset Page: Deaccession Dataset

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Deaccession Dataset Integration

5 participants